Get PDFs to jump to their pages again #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamelafox
commented
Feb 16, 2024
| @@ -37,7 +37,7 @@ class ChatApproach(Approach, ABC): | |||
| Make sure the last question ends with ">>". | |||
| """ | |||
|
|
|||
| query_prompt_template = """Below is a history of the conversation so far, and a new question asked by the user that needs to be answered by searching in a knowledge. | |||
| query_prompt_template = """Below is a history of the conversation so far, and a new question asked by the user that needs to be answered by searching in a knowledge base. | |||
There was a problem hiding this comment.
This was caught by a reader of my blog post today-https://blog.pamelafox.org/2024/02/rag-techniques-cleaning-user-questions.html
Doubt it affects anything as GPTs dont mind lil errors.
pamelafox
commented
Feb 16, 2024
| return ( | ||
| <li className={styles.tListItem}> | ||
| <li className={styles.tListItem} key={ind}> |
There was a problem hiding this comment.
We were getting a bunch of React errors locally from missing key= values. An index isnt the best thing to use but it should be okay for our situation.
pamelafox
commented
Feb 16, 2024
| export const SupportingContent = ({ supportingContent }: Props) => { | ||
| const textItems = Array.isArray(supportingContent) ? supportingContent : supportingContent.text; | ||
| const imageItems = !Array.isArray(supportingContent) ? supportingContent?.images : []; | ||
| return ( | ||
| <ul className={styles.supportingContentNavList}> | ||
| {textItems.map(c => { | ||
| {textItems.map((c, ind) => { |
There was a problem hiding this comment.
Ditto, this was just fixing index. And I moved the HTML inside the class as I couldn't deal with writing the correct Typescript for the separate component. :)
mattgotteiner
approved these changes
Feb 17, 2024
| @@ -34,12 +34,19 @@ export const AnalysisPanel = ({ answer, activeTab, activeCitation, citationHeigh | |||
| const fetchCitation = async () => { | |||
| const token = client ? await getToken(client) : undefined; | |||
| if (activeCitation) { | |||
| // Get hash from the URL as it may contain #page=N | |||
There was a problem hiding this comment.
This makes sense since we download the full object url. Appreciate your fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1245
This PR has a few fixes, but the biggest one is a fix for regression introduced by #1160 which replaced citation URLs with blob URLs. My fix remembers the hash and adds it to the blob URL after, which seems to work correctly in Edge. I couldn't find any documentation as to whether blob URLs formally support hash fragments, but they seem to!
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test