Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper event loop setup #1275

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Proper event loop setup #1275

merged 1 commit into from
Feb 15, 2024

Conversation

pamelafox
Copy link
Collaborator

Purpose

The current code produces a DeprecationWarning in 3.12. This change removes the warning. It looks like this is supported for all our supported versions of Python, per reference at:
https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Create a 3.12 environment
  • Run ./scripts/prepdocs.sh
  • Don't see DeprecationWarning

@pamelafox pamelafox merged commit f90c660 into Azure-Samples:main Feb 15, 2024
10 checks passed
@pamelafox pamelafox deleted the eventloop branch February 15, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants