Fix .NET 8 breaking change (#320)

* Cosmetic

* Update version

* Update nuget

* Fix nuget breaking changes

* Fix async issues

* Remove prefix for constants

* Cosmetic

* Fix build regression

.editorconfig

@@ -207,7 +207,6 @@ dotnet_naming_symbols.constants_with_k.applicable_accessibilities             =
 dotnet_naming_symbols.constants_with_k.required_modifiers                     = const
 
 dotnet_naming_style.constants_with_k_style.capitalization                     = pascal_case
-dotnet_naming_style.constants_with_k_style.required_prefix                    = k
 
 # Constants are PascalCase
 dotnet_naming_rule.constants_should_be_pascal_case.severity = suggestion
@@ -314,6 +313,6 @@ dotnet_diagnostic.CA1852.severity                                             =
 # CA1860: Avoid using 'Enumerable.Any()' extension method
 dotnet_diagnostic.CA1860.severity 											  = suggestion
 
-# CA1861: Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array	
+# CA1861: Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array
 dotnet_diagnostic.CA1861.severity 											  = suggestion
 

src/OpcApplicationConfiguration.cs

@@ -70,8 +70,8 @@ public async Task<ApplicationConfiguration> ConfigureAsync()
         var transportQuotas = new TransportQuotas
         {
             MaxStringLength = OpcMaxStringLength,
-            MaxMessageSize = 4 * 1024 * 1024, // 4MB.
-            MaxByteStringLength = 4 * 1024 * 1024, // 4MB.
+            MaxMessageSize = 4 * 1024 * 1024, // 4 MB.
+            MaxByteStringLength = 4 * 1024 * 1024, // 4 MB.
         };
 
         var operationLimits = new OperationLimits()

tests/DataMonitoringTests.cs

@@ -1,5 +1,6 @@
-namespace OpcPlc.Tests;
-
+namespace OpcPlc.Tests;
+
+using System;
 using System.Linq;
 using FluentAssertions;
 using NUnit.Framework;
@@ -13,7 +14,7 @@ namespace OpcPlc.Tests;
 public class DataMonitoringTests : SubscriptionTestsBase
 {
     // Set any cmd params needed for the plc server explicitly.
-    public DataMonitoringTests() : base(new string[] { })
+    public DataMonitoringTests() : base(Array.Empty<string>())
     {
     }
 

tests/DeterministicAlarmsTests2.cs

@@ -53,7 +53,7 @@ public void VerifyThatTimeForEventsChanges()
 
         NodeShouldHaveStates(doorOpen1, Inactive, Disabled);
 
-        Assert.AreNotEqual(timeForFirstEvent, timeForNextEvent);
+        timeForFirstEvent.Should().NotBe(timeForNextEvent);
     }
 
     private void AdvanceToNextStep()

tests/PlcSimulatorFixture.cs

@@ -77,7 +77,7 @@ public PlcSimulatorFixture(string[] args)
     /// Configure and run the simulator in a background thread, run once for the entire assembly.
     /// The simulator is instrumented with mock time services.
     /// </summary>
-    public async Task Start()
+    public async Task StartAsync()
     {
         Reset();
 
@@ -137,7 +137,7 @@ public async Task Start()
             .GetAwaiter().GetResult());
 
         string endpointUrl = WaitForServerUp();
-        await _log.WriteAsync($"Found server at: {endpointUrl}");
+        await _log.WriteAsync($"Found server at: {endpointUrl}").ConfigureAwait(false);
 
         if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
         {
@@ -146,14 +146,14 @@ public async Task Start()
             // Use the Loopback IP address as a workaround.
             // In contrast, on Windows Azure DevOps builds, this results in issues.
             endpointUrl = $"opc.tcp://{IPAddress.Loopback}:{Port}";
-            await _log.WriteAsync($"Connecting to server URL: {endpointUrl}");
+            await _log.WriteAsync($"Connecting to server URL: {endpointUrl}").ConfigureAwait(false);
         }
 
-        _config = await GetConfigurationAsync();
+        _config = await GetConfigurationAsync().ConfigureAwait(false);
         _serverEndpoint = GetServerEndpoint(endpointUrl);
     }
 
-    public Task Stop()
+    public Task StopAsync()
     {
         // shutdown simulator
         _serverCancellationTokenSource.Cancel();
@@ -223,7 +223,7 @@ private static void Reset()
 
     private async Task<ApplicationConfiguration> GetConfigurationAsync()
     {
-        await _log.WriteLineAsync("Create Application Configuration");
+        await _log.WriteLineAsync("Create Application Configuration").ConfigureAwait(false);
 
         var application = new ApplicationInstance
         {

tests/SimulatorNodesTests.cs

@@ -73,7 +73,7 @@ public void Telemetry_FastNode()
             }
             else
             {
-                Assert.AreEqual(lastValue + 1, value);
+                value.Should().Be(lastValue + 1);
                 lastValue = value;
             }
 
@@ -85,17 +85,17 @@ public void Telemetry_FastNode()
         CallMethod("StopUpdateFastNodes");
 
         var nextValue = ReadValue<uint>(nodeId);
-        Assert.AreEqual(lastValue, nextValue);
+        nextValue.Should().Be(lastValue);
         FireTimersWithPeriod(FromSeconds(1), numberOfTimes: 1);
         nextValue = ReadValue<uint>(nodeId);
-        Assert.AreEqual(lastValue, nextValue);
+        nextValue.Should().Be(lastValue);
         FireTimersWithPeriod(FromSeconds(1), numberOfTimes: 1);
 
         CallMethod("StartUpdateFastNodes");
         FireTimersWithPeriod(FromSeconds(1), numberOfTimes: 1);
 
         nextValue = ReadValue<uint>(nodeId);
-        Assert.AreEqual(lastValue + 1, nextValue);
+        nextValue.Should().Be(lastValue + 1);
     }
 
     [TestCase("DipData", -1000)]

tests/SimulatorTestsBase.cs

@@ -40,16 +40,16 @@ protected SimulatorTestsBase(string[] args = default)
     [OneTimeSetUp]
     public async Task Setup()
     {
-        await _simulator.Start();
-        Session = await _simulator.CreateSessionAsync(GetType().Name);
+        await _simulator.StartAsync().ConfigureAwait(false);
+        Session = await _simulator.CreateSessionAsync(GetType().Name).ConfigureAwait(false);
     }
 
     /// <summary>Closes the OPC-UA session and stops the simulator.</summary>
     [OneTimeTearDown]
     public async Task TearDown()
     {
         Session.Close();
-        await _simulator.Stop();
+        await _simulator.StopAsync().ConfigureAwait(false);
     }
 
     /// <summary>

tests/opc-plc-tests.csproj

@@ -10,7 +10,7 @@
     <PackageReference Include="Bogus" Version="34.0.2" />
     <PackageReference Include="FluentAssertions" Version="6.12.0" />
     <PackageReference Include="Moq" Version="4.20.69" />
-    <PackageReference Include="NUnit" Version="3.14.0" />
+    <PackageReference Include="NUnit" Version="4.0.0" />
     <PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
   </ItemGroup>

tools/scripts/acr-build.ps1

@@ -204,7 +204,7 @@ if (![string]::IsNullOrEmpty($metadata.tag)) {
 $fullImageName = "$($Registry).azurecr.io/$($namespace)$($imageName):$($tagPrefix)$($sourceTag)$($tagPostfix)"
 Write-Host "Full image name: $($fullImageName)"
 
-$manifest = @" 
+$manifest = @"
 image: $($fullImageName)
 tags: [$($tagPrefix)$($latestTag)$($tagPostfix)]
 manifests:

tools/scripts/docker-source.ps1

@@ -52,6 +52,7 @@ if ($projFile) {
             $argumentList += "-r"
             $argumentList += $runtimeId
             $argumentList += "/p:TargetLatestRuntimePatch=true"
+            $argumentList += "--self-contained"
         }
         else {
             $runtimeId = "portable"

version.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://raw.githubusercontent.com/AArnott/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",
-  "version": "2.9.14",
+  "version": "2.9.15",
   "versionHeightOffset": -1,
   "publicReleaseRefSpec": [
     "^refs/heads/main$",