-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable flat directory certificate store for k8s cert-manager compatibility #328
Conversation
|
||
/// <summary> | ||
/// Configures all OPC stack settings. | ||
/// </summary> | ||
public async Task<ApplicationConfiguration> ConfigureAsync() | ||
{ | ||
{ | ||
if (!_flatDirectoryCertStoreInitialized) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this ever called once?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should normally be only called once. In the unit tests it is called for every test though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw: Would it be difficult to add unit tests for this? can be done in separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purpose
Does this introduce a breaking change?
Pull Request Type
How to Test
What to Check
Verify that the following are valid
Other Information