Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable flat directory certificate store for k8s cert-manager compatibility #328

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

cristipogacean
Copy link
Collaborator

@cristipogacean cristipogacean commented Dec 11, 2023

Purpose

  • add support for flat directory certificate store for k8s cert manager compatibility
  • handle .crt and .key certificate types

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information


/// <summary>
/// Configures all OPC stack settings.
/// </summary>
public async Task<ApplicationConfiguration> ConfigureAsync()
{
{
if (!_flatDirectoryCertStoreInitialized)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this ever called once?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should normally be only called once. In the unit tests it is called for every test though.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw: Would it be difficult to add unit tests for this? can be done in separate PR.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@luiscantero luiscantero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cristipogacean cristipogacean merged commit 5407570 into main Dec 12, 2023
14 checks passed
@cristipogacean cristipogacean deleted the crpogace/flatdircertstore branch December 12, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants