Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add custom types into global EncodeableFactory #371

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

koepalex
Copy link
Contributor

@koepalex koepalex commented Jun 26, 2024

Purpose

When used via NuGet package in-memory, the server needs to use its own encodable factory. Otherwise, the client will not load the type definitions for decoding correctly. There is currently no public API to set the encodable factory and it is not possible to provide own implementation, because other classes require the StandardServer or ServerInternalData as objects, so we need to use reflection to set it.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@luiscantero luiscantero merged commit c979045 into Azure-Samples:main Jun 26, 2024
3 checks passed
@koepalex koepalex deleted the no-global-encoding branch June 26, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants