-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Firewall custom DNS server #615
Conversation
Co-authored-by: Jack Tracey <[email protected]>
Co-authored-by: Jack Tracey <[email protected]>
Co-authored-by: Jack Tracey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @juang903, could you also add it to the VWAN Module? https://github.com/Azure/ALZ-Bicep/tree/main/infra-as-code/bicep/modules/vwanConnectivity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @juang903 could you also add the new parameter with its default value to the parameters.all.json
files for each module respectively as well please? 👍
@jtracey93 Thanks, I added the params. I also added params for my last bastion PR since those weren't added previously, hope that's ok. |
Thanks @juang903, all good. Can you please fix the linting errors here: https://github.com/Azure/ALZ-Bicep/actions/runs/5941466329/job/16169596767?pr=615 Installing EditorConfig VSCode extension should help you here |
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
Hi @juang903, Are you able to resolve the linting errors by installing editorConfig in VSCode and formatting the edited files youve touched? |
Hi @jtracey93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
Overview/Summary
Adds support for configuring the custom DNS server used in Azure Firewall
This PR fixes/adds/changes/removes
Testing Evidence
Entered an array of IPs and verified they were set in Azure Firewall DNS. Entered an empty array and verified that Default (azure provided) DNS is selected. No errors on deployment.