Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Firewall custom DNS server #615

Merged
merged 17 commits into from
Sep 9, 2023

Conversation

juang903
Copy link
Contributor

Overview/Summary

Adds support for configuring the custom DNS server used in Azure Firewall

This PR fixes/adds/changes/removes

  1. Adds the options to configure custom DNS server in Azure Firewall
  2. Changes markdown files as appropriate

Testing Evidence

Entered an array of IPs and verified they were set in Azure Firewall DNS. Entered an empty array and verified that Default (azure provided) DNS is selected. No errors on deployment.

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @juang903 could you also add the new parameter with its default value to the parameters.all.json files for each module respectively as well please? 👍

@juang903
Copy link
Contributor Author

@jtracey93 Thanks, I added the params. I also added params for my last bastion PR since those weren't added previously, hope that's ok.

@jtracey93
Copy link
Collaborator

Thanks @juang903, all good. Can you please fix the linting errors here: https://github.com/Azure/ALZ-Bicep/actions/runs/5941466329/job/16169596767?pr=615

Installing EditorConfig VSCode extension should help you here

@microsoft-github-policy-service
Copy link
Contributor

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@jtracey93
Copy link
Collaborator

Hi @juang903,

Are you able to resolve the linting errors by installing editorConfig in VSCode and formatting the edited files youve touched?

@juang903
Copy link
Contributor Author

juang903 commented Sep 6, 2023

Hi @jtracey93
I think the linting errors are resolved now.

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 merged commit 529d746 into Azure:main Sep 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Azure Firewall custom DNS servers as parameter and resource setting
2 participants