Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN Gateway P2S support #617

Merged
merged 17 commits into from
Oct 4, 2023
Merged

VPN Gateway P2S support #617

merged 17 commits into from
Oct 4, 2023

Conversation

juang903
Copy link
Contributor

Overview/Summary

Adds support for configuring P2S connections in the VPN gateway

This PR fixes/adds/changes/removes

  1. Adds the option to configure P2S VPN connections

Testing Evidence

Tested by deploying config for AAD, Certificate, and Radius authentication.

@juang903
Copy link
Contributor Author

I have some sample parameters that I would like to add, but not sure where this is best documented. Please advise.
The sample parameters are for vpnClientConfiguration in hubNetworking.parameters.all.json. Here is an example for AAD auth...
"vpnClientConfiguration": { "vpnClientAddressPool": { "addressPrefixes": [ "172.16.0.0/24" ] }, "vpnClientProtocols": [ "OpenVPN" ], "vpnAuthenticationTypes": [ "AAD" ], "aadTenant": "https://login.microsoftonline.com/**My-Tenant-ID**", "aadAudience": "41b23e61-6c1e-4545-b367-cd054e0ed4b4", "aadIssuer": "https://sts.windows.net/**My-Tenant-ID**/" }

@jtracey93
Copy link
Collaborator

@juang903 consider adding them to the readme in the parameters section like we did for management groups: https://github.com/Azure/ALZ-Bicep/tree/main/infra-as-code/bicep/modules/managementGroups#parameters

@microsoft-github-policy-service
Copy link
Contributor

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@juang903
Copy link
Contributor Author

juang903 commented Sep 6, 2023

@jtracey93 Thanks. I added an example of how to set this config in the readme.

@oZakari oZakari self-assigned this Oct 4, 2023
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some minor linting issues, but everything else looks good to me! Thank you for your contribution, @juang903!

@oZakari oZakari merged commit b0409fa into Azure:main Oct 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants