-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPN Gateway P2S support #617
Conversation
Co-authored-by: Jack Tracey <[email protected]>
Co-authored-by: Jack Tracey <[email protected]>
Co-authored-by: Jack Tracey <[email protected]>
I have some sample parameters that I would like to add, but not sure where this is best documented. Please advise. |
@juang903 consider adding them to the readme in the parameters section like we did for management groups: https://github.com/Azure/ALZ-Bicep/tree/main/infra-as-code/bicep/modules/managementGroups#parameters |
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
@jtracey93 Thanks. I added an example of how to set this config in the readme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed some minor linting issues, but everything else looks good to me! Thank you for your contribution, @juang903!
Overview/Summary
Adds support for configuring P2S connections in the VPN gateway
This PR fixes/adds/changes/removes
Testing Evidence
Tested by deploying config for AAD, Certificate, and Radius authentication.