Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type element to contributing-wiki #674

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

picccard
Copy link
Contributor

@picccard picccard commented Nov 5, 2023

Overview/Summary

User-defined data types for bicep is GA and the contribution guide needs updating.
There already exists PRs with the new type-keyword (#673 and #656)

The ALZ-Bicep team needs to decide on a naming prefix for this element.

This PR fixes/adds/changes/removes

  1. Adds guidelines for user-defined data types in the contributing-wiki

Breaking Changes

  1. None

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

docs/wiki/Contributing.md Outdated Show resolved Hide resolved
@jtracey93 jtracey93 merged commit 87e138c into Azure:main Nov 5, 2023
4 checks passed
@picccard picccard deleted the update-contribution-guidelines branch November 8, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants