-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add Resource Locking to ALZ Bicep Modules #712
Conversation
Thanks @DaFitRobsta! Will go through this PR later this week. 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DaFitRobsta, for the resource group module I see there is a new module called resourceGroupLock.bicep. Can we instead just use the resource lock provider as you have done for the other modules instead?
infra-as-code/bicep/modules/privateDnsZones/privateDnsZones.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/privateDnsZones/privateDnsZones.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/privateDnsZones/privateDnsZones.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/vwanConnectivity/parameters/vwanConnectivity.parameters.all.json
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/spokeNetworking/parameters/spokeNetworking.parameters.all.json
Outdated
Show resolved
Hide resolved
Hey @oZakari, |
LGTM Co-authored-by: Zach Trocinski <[email protected]>
Thanks for finding this! Co-authored-by: Zach Trocinski <[email protected]>
LGTM Co-authored-by: Zach Trocinski <[email protected]>
LGTM Co-authored-by: Zach Trocinski <[email protected]>
Ah, that makes perfect sense. Thanks for the clarification on that! |
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
Hey @DaFitRobsta, the ValidateAzCloud pipeline failed due to parPublicIPLock not being declared within the hub networking module. Could you add that in when you get chance please. After adding the fix, you can run put /azp run validateazcloud in a comment to re-trigger the pipeline. |
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
Overview/Summary
Adds the support for resource locking in all modules for resources that support resource locks.
See AB#30524 for additional details of feature request.
In response to #608
This PR fixes/adds/changes/removes
Breaking Changes
None
Testing Evidence
Each module that was updated to support Resource Locking was tested with successful deployments. Testing included setting the global parameter to different values as individual resources to validate resource locking logic.
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch