Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Adding conditional statements for subnet references #748

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Mar 21, 2024

Overview/Summary

Fixes #746 and also addresses related similar scenario if a customer removed the GatewaySubnet object from parSubnets by adding conditionals to the resource references for those subnets.

This PR fixes/adds/changes/removes

  1. Add conditional statement for existing resource reference for GatewaySubnet
  2. Add conditional statement for existing resource reference for FirewallSubnet

Breaking Changes

  1. None

Testing Evidence

Ran a deployment with parExpressRouteGatewayEnabled, parVpnGatewayEnabled, and parAzFirewallName set to false as well as their parSubnet objects removed.

image

As part of this Pull Request I have

@oZakari oZakari merged commit 9e5964a into Azure:main Mar 21, 2024
18 checks passed
@oZakari oZakari deleted the bug-746 branch March 21, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment alz-bicep-4a-hubspoke fails when AzureFirewall disabled
1 participant