Skip to content

Commit

Permalink
Cleans up unused args in muo.NewReconciler
Browse files Browse the repository at this point in the history
  • Loading branch information
m1kola committed Feb 25, 2022
1 parent a0a07e3 commit 24fb188
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 1 addition & 3 deletions cmd/aro/operator.go
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,7 @@ func operator(ctx context.Context, log *logrus.Entry) error {
arocli, maocli, kubernetescli, imageregistrycli)).SetupWithManager(mgr); err != nil {
return fmt.Errorf("unable to create controller %s: %v", controllers.StorageAccountsControllerName, err)
}
if err = (muo.NewReconciler(
log.WithField("controller", controllers.ManagedUpgradeOperatorControllerName),
arocli, kubernetescli, dh)).SetupWithManager(mgr); err != nil {
if err = (muo.NewReconciler(arocli, kubernetescli, dh)).SetupWithManager(mgr); err != nil {
return fmt.Errorf("unable to create controller %s: %v", controllers.ManagedUpgradeOperatorControllerName, err)
}
}
Expand Down
3 changes: 1 addition & 2 deletions pkg/operator/controllers/muo/muo_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"strings"
"time"

"github.com/sirupsen/logrus"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/wait"
"k8s.io/client-go/kubernetes"
Expand Down Expand Up @@ -39,7 +38,7 @@ type Reconciler struct {
readinessTimeout time.Duration
}

func NewReconciler(log *logrus.Entry, arocli aroclient.Interface, kubernetescli kubernetes.Interface, dh dynamichelper.Interface) *Reconciler {
func NewReconciler(arocli aroclient.Interface, kubernetescli kubernetes.Interface, dh dynamichelper.Interface) *Reconciler {
return &Reconciler{
arocli: arocli,
deployer: newDeployer(kubernetescli, dh),
Expand Down

0 comments on commit 24fb188

Please sign in to comment.