Fail MUO test if we expect an error but don't get one

Azure · Apr 19, 2022 · 5a79d8f · 5a79d8f
1 parent 6495779
commit 5a79d8f
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/pkg/operator/controllers/muo/muo_controller_test.go b/pkg/operator/controllers/muo/muo_controller_test.go
@@ -265,12 +265,12 @@ func TestMUOReconciler(t *testing.T) {
 				readinessPollTime: 1 * time.Second,
 			}
 			_, err := r.Reconcile(context.Background(), reconcile.Request{})
+			if err != nil && err.Error() != tt.wantErr {
+				t.Errorf("got error '%v', wanted error '%v'", err, tt.wantErr)
+			}
+
 			if err == nil && tt.wantErr != "" {
-				t.Error(err)
-			} else if err != nil {
-				if err.Error() != tt.wantErr {
-					t.Errorf("wanted '%v', got '%v'", tt.wantErr, err)
-				}
+				t.Errorf("did not get an error, but wanted error '%v'", tt.wantErr)
 			}
 		})
 	}