remove network acceleration due to issues discovered #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ross-bryan
added
size-small
ross-bryan
requested review from
bennerv,
hawkowl,
jewzaam,
m1kola,
mwoodson and
rogbas
as code owners
|
testing with accelerated networking disabled on gateway is going well so far, but maybe we wont even need this if underlying issues of accelerated networking feature can be resolved in a timely fashion |
|
Please rebase pull request. |
ross-bryan
force-pushed
the
egress_no_accelerated_networking
branch
from
a78982e
to
fdba8b2
Compare
github-actions
bot
added
needs-rebase
|
Please rebase pull request. |
bennerv
previously approved these changes
Feb 2, 2022
reapply the primary tag make generate
ross-bryan
force-pushed
the
egress_no_accelerated_networking
branch
from
fdba8b2
to
1cfa9a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes connection reset issues with egress lockdown
What this PR does / why we need it:
sets accelerated networking on the gateway VM to false
Test plan for issue:
deploy this code in full service dev rp, attempt to reproduce known egress issues, standard e2e
Is there any documentation that needs to be updated for this PR?
maybe. pending additional testing results and response from azure networking team