Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite FIPs environment variable in CI VMs #1936

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

bennerv
Copy link
Collaborator

@bennerv bennerv commented Feb 3, 2022

Which issue this PR addresses:

Fixes my dumb mistake in a different PR. Set the GOLANG_FIPS capability for the ADO agent instead of overwriting it.

What this PR does / why we need it:

Set the GOLANG_FIPS capability for the ADO agent instead of overwriting it.

Test plan for issue:

redeployed CI VMs and the capability is now present.

Is there any documentation that needs to be updated for this PR?

No

Copy link
Contributor

@ross-bryan ross-bryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petrkotas petrkotas merged commit 178d53b into Azure:master Feb 4, 2022
@bennerv bennerv deleted the fix-fips-env-ci branch February 4, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants