Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use the correct variable syntax for updated variables in pipelines #1951

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

bennerv
Copy link
Collaborator

@bennerv bennerv commented Feb 7, 2022

Which issue this PR addresses:

Variables need to be referenced in ADO with variables.varName, not parameters.varName. I made a mistake in a previous PR.

What this PR does / why we need it:

See above

Test plan for issue:

Test by running

Is there any documentation that needs to be updated for this PR?

no

@bennerv
Copy link
Collaborator Author

bennerv commented Feb 7, 2022

@bennerv bennerv added bug Something isn't working next-release To be included in the next RP release rollout labels Feb 7, 2022
@bennerv
Copy link
Collaborator Author

bennerv commented Feb 7, 2022

Worked as expected. @petrkotas if you could approve when you get in tomorrow and merge that would be great.

Copy link
Contributor

@ross-bryan ross-bryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ross-bryan ross-bryan merged commit acecd05 into Azure:master Feb 8, 2022
@bennerv bennerv deleted the pipelines-bugfix-for-variables branch May 4, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next-release To be included in the next RP release rollout ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants