Refactors operator requeues #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds the clarifying comment on requeues into the checker controller * Removes `Requeue: true` in places where we use `RequeueAfter` as it is has no effect.
m1kola
requested review from
jewzaam,
bennerv,
hawkowl,
mwoodson,
rogbas,
petrkotas and
ross-bryan
as code owners
m1kola
commented
Feb 15, 2022
| @@ -101,9 +101,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, request ctrl.Request) (ctrl. | |||
| deadline := t.Add(gracePeriod) | |||
| now := time.Now() | |||
| if deadline.After(now) { | |||
| return reconcile.Result{ | |||
| RequeueAfter: deadline.Sub(now), | |||
| }, err | |||
There was a problem hiding this comment.
In this case - err is always nil as we return above when err is not nil.
s-amann
approved these changes
Feb 15, 2022
SudoBrendan
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Requeue: truein places where we useRequeueAfteras it is has no effect.Test plan for issue:
Unit tests updated where applicable.
Is there any documentation that needs to be updated for this PR?
No, just refactoring