Add node-selector to MUO Namespace #2022
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennerv
requested review from
jewzaam,
m1kola,
hawkowl,
mwoodson,
rogbas,
petrkotas and
ross-bryan
as code owners
ross-bryan
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes a case where a customer sets a default node selector on their scheduler and pods cannot schedule on master nodes.
What this PR does / why we need it:
Ensures that the namespace node selector overrides any custom scheduler in place causing MUO openshift workloads from scheduling.
Test plan for issue:
Tested on a cluster experiencing the issue and it resolved it.
Is there any documentation that needs to be updated for this PR?
no