-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added changes to make local e2e test work/ update doc #2036
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,8 +69,17 @@ clean_e2e_db(){ | |
|
||
# TODO: CLUSTER and is also recalculated in multiple places | ||
# in the billing pipelines :-( | ||
export CLUSTER="v4-e2e-V$BUILD_BUILDID-$LOCATION" | ||
export DATABASE_NAME="v4-e2e-V$BUILD_BUILDID-$LOCATION" | ||
|
||
|
||
# if LOCAL_E2E is set, set the value with the local test names | ||
# If it it not set, it defaults to the build ID | ||
if [ -z "${LOCAL_E2E}" ] ; then | ||
export CLUSTER="v4-e2e-V$BUILD_BUILDID-$LOCATION" | ||
export DATABASE_NAME="v4-e2e-V$BUILD_BUILDID-$LOCATION" | ||
else | ||
export CLUSTER="$USER-local-e2e" | ||
export DATABASE_NAME="$USER-local-e2e" | ||
fi | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This name might not be optimal, I couldn't come up with a better name though. Please feel free to give suggestions |
||
|
||
echo "######################################" | ||
echo "##### ARO V4 E2e helper sourced ######" | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK you can also use an existing cluster and just run make test-e2e if you let the CLUSTER variable point to it. Maybe we should also document this, because sometimes you might want to use an existing one.