Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Fix: Replace strings.Title with Caser #2341

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

SudoBrendan
Copy link
Collaborator

@SudoBrendan SudoBrendan commented Aug 22, 2022

Which issue this PR addresses:

One of 100 things on the way to 4.11...

What this PR does / why we need it:

Golang 1.18 deprecates the strings.Title function, but a fix is available before we bump golang versions so I'm doing that here in it's own PR.

Test plan for issue:

make generate still returns the same swagger files with identical filename casing (e.g. "openShiftClusters" still gets transformed to "OpenShiftClusters"), this is a no-op refactor.

Is there any documentation that needs to be updated for this PR?

N/A

@SudoBrendan SudoBrendan changed the title Replace strings.Title with caser Deprecation Fix: Replace strings.Title with Caser Aug 22, 2022
Copy link
Collaborator

@bennerv bennerv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - following recommendation of the golang devs themselves. +1

@SudoBrendan
Copy link
Collaborator Author

lgtm - following recommendation of the golang devs themselves. +1

The real win, is that now we can FINALLY rename our service to ":rocket:OpenShift" and not worry about those darn unicode capitalization issues! :sunglasses: \s

Copy link
Member

@petrkotas petrkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SudoBrendan Perfect, thank you!

@bennerv bennerv merged commit ef6cf43 into Azure:master Aug 23, 2022
@bennerv bennerv deleted the remove-strings-title branch August 23, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants