Run local development and PR E2E in podman #2817
Conversation
|
Please rebase pull request. |
github-actions
bot
added
needs-rebase
|
Please rebase pull request. |
hawkowl
force-pushed
the
hawkowl/local-dev-podman
branch
from
876bc4c
to
fee0a5c
Compare
hawkowl
force-pushed
the
hawkowl/local-dev-podman
branch
3 times, most recently
from
e62087b
to
94cd910
Compare
hawkowl
changed the title
hawkowl
added
enhancement
|
Please rebase pull request. |
hawkowl
added
priority-high
hawkowl
force-pushed
the
hawkowl/local-dev-podman
branch
from
94cd910
to
0d146dd
Compare
github-actions
bot
added
needs-rebase
|
Please rebase pull request. |
hawkowl
force-pushed
the
hawkowl/local-dev-podman
branch
from
0d146dd
to
0ea812d
Compare
hawkowl
force-pushed
the
hawkowl/local-dev-podman
branch
2 times, most recently
from
29be917
to
514acd1
Compare
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hawkowl
force-pushed
the
hawkowl/local-dev-podman
branch
from
514acd1
to
088e109
Compare
| }), | ||
| steps.Action(func(context.Context) error { return m.createSecrets(ctx, doc, sub) }), | ||
| steps.Action(func(context.Context) error { return m.startContainer(ctx, version) }), | ||
| steps.Condition(m.containerFinished, 60*time.Minute, false), |
There was a problem hiding this comment.
followup idea: do we need a 60m timeout now? I think that hive install times are typically 15-20 minutes once the container is up, no?
There was a problem hiding this comment.
except in eastus2 :')
Co-authored-by: Jeremy Facchetti <[email protected]>
hawkowl
force-pushed
the
hawkowl/local-dev-podman
branch
from
088e109
to
8661e32
Compare
| build-tags: | ||
| - "aro" | ||
| - "containers_image_openpgp" | ||
| - "exclude_graphdriver_devicemapper" | ||
| - "exclude_graphdriver_btrfs" |
There was a problem hiding this comment.
does this have a reason to be in this PR? or is it just some extra change bundled in it?
There was a problem hiding this comment.
Podman's bindings vendors in more of the image lib that causes build dep side effects.
There was a problem hiding this comment.
wondering if these changes belong in this pr too
There was a problem hiding this comment.
As above, these flags need to be changed. I decided to clean it up a smidge, since it will make the diff when the aro build tag is removed a little bit smaller.
There was a problem hiding this comment.
why do we use ginkgo and gomega here? these are standard unit tests
There was a problem hiding this comment.
We use gomega in some other places, and I've got mildly sick of dealing with stdlib golang testing, so I just wrote it in ginkgo instead.
There was a problem hiding this comment.
what about ginkgo? We only use it in e2e, we should have some consistency, we should either use it everywhere in pkg or not at all
There was a problem hiding this comment.
can you explain why ginkgo and gomega are needed here? a comment would be nice in the file, since we are only using those in the e2e and not in pkg
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-2532
What this PR does / why we need it:
Runs local development and PR E2E in podman, instead of directly. Removes the remaining Installer dependencies.
Test plan for issue:
Local testing, E2E.
Is there any documentation that needs to be updated for this PR?
Some local dev documentation likely needs revising.