ARO-3054 - Set OpenShift Version during Cluster Creation #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…helps/aro-3054/e2e-parameter
Taphelps/aro 3054/e2e parameter
tphelps93
changed the title
|
@microsoft-github-policy-service agree company="CloudFit Software" |
updated Create call with OSVersion
|
Please rebase pull request. |
tphelps93
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan and
ellis-johnson
as code owners
cadenmarchese
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality for clusters creation to use a specified version of OpenShift.
Testing
A portion of this code change relies on input from the user in the RP Pipeline in ARO-Pipelines and that input to be passed as an environment variable (OS_CLUSTER_VERSION). That portion has been tested locally and it does successfully take the input and pass it to the script.
The changes made in the ARO-RP simply set the OS_CLUSTER_VERSION to a variable (osClusterVersion) that is passed in as an argument to the Create function call, the Create function calls the createCluster function which takes osClusterVersion as an argument, and that is utilized as the Version key in the ClusterProfile struct.
We want the functionality to remain the same if no version is passed in by the user.
This is accomplished by the omitempty in the ClusterProfile struct. If the value of the osClusterVersion is null, an empty string, etc then it should not include that key/value. I tested this locally and it does indeed, leave out the version when an empty string is passed.
Next steps would be to merge this PR and test this end-to-end.
JIRA Task