Always log error (if applicable) on failed deployment attempts #2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimorris27
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan and
ellis-johnson
as code owners
cadenmarchese
approved these changes
Jun 5, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Came up in Slack thread about most recent RP release. When I updated this error handling code a few months ago, I forgot to ensure that the error on failed deployments is always logged regardless of what type of error it is.
What this PR does / why we need it:
Prior to this PR, errors on failed deployments would only be logged if it was the last deployment attempt or the error was known (specifically the known error related to the RP LB). This PR makes it so that the error is always logged for any failed deployment.
Test plan for issue:
N/A
Is there any documentation that needs to be updated for this PR?
N/A