Propagate errors of ARO ImageConfig controller to ARO Operator

[SrinivasAtmakuri]

Which issue this PR addresses:

JIRA: https://issues.redhat.com/browse/ARO-3272

Fixes

What this PR does / why we need it:

Test plan for issue:

Is there any documentation that needs to be updated for this PR?

Based on changes of: #2899

[SudoBrendan]

Hey, thanks for the PR! There's great progress here, but this work isn't complete yet. Moving over to the base controller will now enable you to use the helper functions of the base to merge the errors of this controller into the ARO Operator status. This should happen for anything that would result in error states for this controller.

Here's an example of a call: https://github.com/Azure/ARO-RP/blob/master/pkg/operator/controllers/machineset/machineset_controller.go#L62

[tsatam]

Additionally, as Brendan has mentioned, since the goal of this change is to propagate error cases as conditions on the operator, I'd like to see that reflected in the test cases. You can get an example of how to do that in the machineset controller tests as well: https://github.com/Azure/ARO-RP/blob/master/pkg/operator/controllers/machineset/machineset_controller_test.go

[SudoBrendan]

My re-review was requested, but I don't see the changes suggested implemented. We should see:

1. Status of the controller going to the operator, via the helpers
2. Test cases that showcase how those errors manifest as conditions on the operator.

old