Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow long-paths on git checkout for SDL onebranch steps #2993

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

bennerv
Copy link
Collaborator

@bennerv bennerv commented Jun 27, 2023

Which issue this PR addresses:

Allow longpaths git checkout option as we have files longer than "supported" on windows git.

What this PR does / why we need it:

Allows us to build our binary

Test plan for issue:

We ran against the pull request PR, it succeeded.

Is there any documentation that needs to be updated for this PR?

No. Link to doc though: https://eng.ms/docs/cloud-ai-platform/azure-edge-platform-aep/aep-engineering-systems/productivity-and-experiences/onebranch-platform-services/onebranch/build/container-based-workflow/git-clone-options

@bennerv bennerv force-pushed the run-sdl-scanning-on-linux branch 2 times, most recently from 0ef4cd0 to 7a95465 Compare June 27, 2023 14:18
@bennerv bennerv changed the title Run sdl scanning on linux hosts Allow long-paths on git checkout for SDL onebranch steps Jun 27, 2023
@bennerv bennerv added ready-for-review next-release To be included in the next RP release rollout labels Jun 27, 2023
Copy link
Member

@petrkotas petrkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@dem4gus dem4gus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you old Windows APIs.

@bennerv bennerv merged commit e34c6d6 into Azure:master Jun 27, 2023
@bennerv bennerv deleted the run-sdl-scanning-on-linux branch June 27, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release To be included in the next RP release rollout ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants