Read installer image digests from an environment variable #3009
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on a couple Azure DevOps pull requests:
✅ RP-Config : Add installerImageDigests to global configurations
✅ ARO.Pipelines : Add INSTALLER_IMAGE_DIGESTS env to update-aro-openshift-versions
and a correction:
✅ ARO.Pipelines : Base64-encode INSTALLER_IMAGE_DIGESTS
Which issue this PR addresses:
[ARO-3523] Move the ARO-Installer Image Digests to RP-Config
What this PR does / why we need it:
Changes
aro update-versions
to read ARO-Installer image digests from an environment variable named "INSTALLER_IMAGE_DIGESTS" which contains data from RP-Config."INSTALLER_IMAGE_DIGESTS" should be a JSON-formatted mapping of
"MAJOR.MINOR"
OpenShift versions to an image digest (e.g.{"4.10": "sha256:...", ...}
).Note: For this to work in Azure DevOps pipelines, the "INSTALLER_IMAGE_DIGESTS" content is Base64-encoded because it ends up embedded in build artifact files that are also in JSON format, which otherwise messes up JSON parsing. This is an unfortunate implementation detail that is not imposed on local development mode. For convenience, local development mode expects "INSTALLER_IMAGE_DIGESTS" content to be raw JSON as shown above.
Test plan for issue:
Local development mode testing and pipeline execution for public INT:
Is there any documentation that needs to be updated for this PR?
Updating the ARO-Installer image digests procedure will change from modifying ARO-RP code to modifying RP-Config.