Update guardian suppression rules #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-fairchild
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
ellis-johnson,
yjst2012 and
anshulvermapatel
as code owners
[Vendored docker swagger api document causing errors.](https://msazure.visualstudio.com/AzureRedHatOpenShift/_build/results?buildId=76389191&view=logs&j=096205eb-4599-56da-affa-13246cc49eac&t=7e5c3140-9b2b-5395-0e58-9e02fe0de382&l=89) Note that the .gdnsuppress file generated by the pipeline now is "hydrated" with all identifying information removed, including the file location by default.
s-fairchild
force-pushed
the
update-guardian-rules
branch
from
38e0b98
to
b753fe4
Compare
s-amann
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the .gdnsuppress file generated by the pipeline now is "hydrated" with all identifying information removed, including the file location by default.
Which issue this PR addresses:
Fixes
Vendored docker swagger api document causing errors.
Updates unit test to not trigger guardian credscan.
New guardian rules are causing an old test to throw an error
What this PR does / why we need it:
Test plan for issue:
Is there any documentation that needs to be updated for this PR?