-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NSG e2e error #3057
Fix NSG e2e error #3057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we elaborate on the issue, why it's an issue, and what this PR does to fix it?
Please rebase pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the e2e test ARO Operator - Azure Subnet Reconciler
needs updating to detect if it's a preconfigured NSG cluster. If so, we should skip the e2e test for reconciling the NSG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nwnt for the update. It seems all is addressed now.
Please rebase pull request. |
update to go 1.18.10
eb9df50
a426616
to
eb9df50
Compare
Please rebase pull request. |
eb9df50
to
0ac69cb
Compare
602938f
to
4643261
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nwnt thank you for the updates, I believe all comments are addressed now.
@@ -342,6 +342,15 @@ var _ = Describe("ARO Operator - Azure Subnet Reconciler", func() { | |||
} | |||
|
|||
BeforeEach(func(ctx context.Context) { | |||
// TODO remove this when GA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bennerv I think this is what you were asking for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it wasn't a remove when GA, but a "use the cluster document API field when GA"
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
I cleared up with @bennerv that this is good to go. |
Co-authored-by: Amber Brown <[email protected]>
Original discussion thread:
https://redhat-external.slack.com/archives/C03F6AA3HDH/p1689891751922919
Which issue this PR addresses:
Fixes: the spring 239 release failure, ARO-3293
It also includes the changes reverted by #3058
What this PR does / why we need it:
Fix the subtle error found during the e2e test in Dev release. The error occurred when the new NSG validate function is called for the FP before the flag alternation in
checkPreconfiguredNSG
called by validateSubnets. In e2e, the subnets will not have any NSG, but the new NSG validation accesses it. That's why it's giving a nil pointer reference error.Test plan for issue:
e2e and CI are now passed.
Is there any documentation that needs to be updated for this PR?
N/A