Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the uid in containerinstall code #3066

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

hawkowl
Copy link
Collaborator

@hawkowl hawkowl commented Jul 27, 2023

Which issue this PR addresses:

Fixes the need for further docs in https://issues.redhat.com/browse/ARO-3710

What this PR does / why we need it:

It doesn't matter if this runs as 0, since rootless podman should do it fine.

Test plan for issue:

CI/E2E

Is there any documentation that needs to be updated for this PR?

N/A

ellis-johnson
ellis-johnson previously approved these changes Jul 27, 2023
Copy link
Contributor

@ellis-johnson ellis-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hawkowl hawkowl force-pushed the hawkowl/uid-in-containerinstall branch from edc119c to cb663b0 Compare July 28, 2023 00:22
@hawkowl hawkowl added size-small Size small next-up ready-for-review skippy pull requests raised by member of Team Skippy labels Jul 28, 2023
Copy link
Contributor

@ellis-johnson ellis-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (again)

@hawkowl
Copy link
Collaborator Author

hawkowl commented Jul 28, 2023

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hawkowl hawkowl merged commit 06cfba5 into Azure:master Jul 28, 2023
18 checks passed
@hawkowl hawkowl deleted the hawkowl/uid-in-containerinstall branch July 31, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-up ready-for-review size-small Size small skippy pull requests raised by member of Team Skippy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants