Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pkg/api dependencies on util/immutable to api/util/immutable #3079

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Move pkg/api dependencies on util/immutable to api/util/immutable #3079

merged 2 commits into from
Aug 9, 2023

Conversation

hawkowl
Copy link
Collaborator

@hawkowl hawkowl commented Aug 3, 2023

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-3864

What this PR does / why we need it:

Moves a dependency that is only used in pkg/api/ into pkg/api. Depends on #3070

Test plan for issue:

Unit tests

Is there any documentation that needs to be updated for this PR?

N/A

@hawkowl hawkowl added ready-for-review go Pull requests that update Go code skippy pull requests raised by member of Team Skippy labels Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Please rebase pull request.

@github-actions github-actions bot added the needs-rebase branch needs a rebase label Aug 3, 2023
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Aug 3, 2023
tsatam
tsatam approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@tsatam tsatam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward change, LGTM!

I'm trusting CI being 🟢 to have validated that the package isn't being used outside of pkg/api, and that there are no changes to generated content as a result of this.

@hawkowl
Copy link
Collaborator Author

hawkowl commented Aug 9, 2023

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hawkowl hawkowl merged commit c8d10ff into Azure:master Aug 9, 2023
18 checks passed
@hawkowl hawkowl deleted the hawkowl/api-util-immutable branch August 9, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsatam tsatam tsatam approved these changes

@SudoBrendan SudoBrendan SudoBrendan approved these changes

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam is a code owner

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@petrkotas petrkotas Awaiting requested review from petrkotas petrkotas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker is a code owner

@facchettos facchettos Awaiting requested review from facchettos

@cadenmarchese cadenmarchese Awaiting requested review from cadenmarchese cadenmarchese is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@s-amann s-amann Awaiting requested review from s-amann

@ellis-johnson ellis-johnson Awaiting requested review from ellis-johnson

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 is a code owner

@anshulvermapatel anshulvermapatel Awaiting requested review from anshulvermapatel anshulvermapatel is a code owner

Assignees
No one assigned
Labels
go Pull requests that update Go code ready-for-review skippy pull requests raised by member of Team Skippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawkowl @tsatam @SudoBrendan