Fix local make admin.kubeconfig #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadenmarchese
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
UlrichSchlueter,
s-amann,
SudoBrendan,
ellis-johnson,
yjst2012 and
anshulvermapatel
as code owners
tsatam
approved these changes
Aug 15, 2023
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ross-bryan
approved these changes
Aug 23, 2023
bennerv
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes an issue with running
make admin.kubeconfiglocally. The issue was introduced in an earlier PR.What this PR does / why we need it:
We should no longer need to specify path when invoking jq since we now have #3050. Specifying the path to jq fails locally when running make admin.kubeconfig unless a jq binary is present in the current working directory.
Test plan for issue:
make admin.kubeconfigshould pass.Is there any documentation that needs to be updated for this PR?