Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeQL GitHub Action #3105

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Fix CodeQL GitHub Action #3105

merged 2 commits into from
Aug 17, 2023

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented Aug 16, 2023

Which issue this PR addresses:

Fixes ARO-3957

What this PR does / why we need it:

  • Removes Golang CodeQL check from ADO CI pipeline
  • Adds Golang CodeQL check to the existing GitHub Action, but uses a hosted 1ES pool for golang

Test plan for issue:

This is a presubmit CI job, so a green test here means :shipit:

Is there any documentation that needs to be updated for this PR?

Yes, will need to document the 1ES pool

@cblecker cblecker force-pushed the fix-codeql branch 16 times, most recently from 5dd51ca to d788e96 Compare August 17, 2023 18:07
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

bennerv
bennerv previously approved these changes Aug 17, 2023
Copy link
Collaborator

@bennerv bennerv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - one question

.github/workflows/codeql-analysis.yml Outdated Show resolved Hide resolved
@cblecker cblecker merged commit 9812067 into Azure:master Aug 17, 2023
17 of 18 checks passed
@cblecker cblecker deleted the fix-codeql branch August 17, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants