Revendor hive to 70b666ec8 #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hive needs to be vendored at the same commit level as it is deployed in ARO. One reason, as described in the linked card, is that changes in APIs can lead to unintended edits during round-trip Get()/Update() flows. ARO-3801
2uasimojo
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
anshulvermapatel and
hlipsig
as code owners
|
@microsoft-github-policy-service agree company="Red Hat" |
|
/assign @bennerv ? |
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
These seem latent, but necessary for the previous commit to pass CI.
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
cblecker
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hive needs to be vendored at the same commit level as it is deployed in ARO. One reason, as described in the linked card, is that changes in APIs can lead to unintended edits during round-trip Get()/Update() flows.
Which issue this PR addresses:
Partially Fixes ARO-3801
What this PR does / why we need it:
Vendored hive code needs to be at the same commit level as what's deployed. This will avoid many issues; but the one in play here is round tripping with Get() and Update()
Test plan for issue:
Build. Deploy. Try again.
Is there any documentation that needs to be updated for this PR?
Is there documentation on the CI/CD process? It should be updated to note that ARO-RP needs to revendor hive to match whatever commit level is going to be deployed.