-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create oic storage account in dev #3404
Merged
SudoBrendan
merged 7 commits into
Azure:master
from
cadenmarchese:dev-oidc-storage-account
Feb 27, 2024
Merged
Create oic storage account in dev #3404
SudoBrendan
merged 7 commits into
Azure:master
from
cadenmarchese:dev-oidc-storage-account
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadenmarchese
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
jharrington22,
cblecker,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
dofinn
as code owners
February 13, 2024 15:11
gouthamMN
reviewed
Feb 15, 2024
gouthamMN
reviewed
Feb 15, 2024
gouthamMN
previously approved these changes
Feb 16, 2024
niontive
approved these changes
Feb 27, 2024
hlipsig
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SudoBrendan
reviewed
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If anonymous/unauthenticated access to this SA is a requirement, LGTM - I'm not sure if we need that or not?
SudoBrendan
approved these changes
Feb 27, 2024
cadenmarchese
added a commit
to cadenmarchese/ARO-RP
that referenced
this pull request
Mar 5, 2024
UlrichSchlueter
pushed a commit
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
https://issues.redhat.com/browse/ARO-5029
What this PR does / why we need it:
Uses AKS and AZWI storage account examples as inspiration.
Test plan for issue:
Once the PR is approved and merged I can go and apply this to our shared environments.
Is there any documentation that needs to be updated for this PR?
Yes - updated.