Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create oic storage account in dev #3404

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

cadenmarchese
Copy link
Collaborator

@cadenmarchese cadenmarchese commented Feb 13, 2024

Which issue this PR addresses:

https://issues.redhat.com/browse/ARO-5029

What this PR does / why we need it:

  • Creates storage account in dev environments, named after the resource group so that we have unique names
  • Uses template function to remove dashes from storage account names - our resource groups commonly have dashes (v4-eastus, aro-australiaeast, aro-shared-cluster, etc...) and the storage account names don't allow these.
    • Also ensures storage account name doesn't exceed 24 characters.
  • Creates role assignment on the RP MSI in a full env, or the RP service principal in a shared env
  • Updates docs
  • Keeps deployment of oic resources separate from other ARM templates to maintain reusability

Uses AKS and AZWI storage account examples as inspiration.

Test plan for issue:

Once the PR is approved and merged I can go and apply this to our shared environments.

Is there any documentation that needs to be updated for this PR?

Yes - updated.

@cadenmarchese cadenmarchese marked this pull request as ready for review February 15, 2024 21:43
gouthamMN
gouthamMN previously approved these changes Feb 16, 2024
Copy link
Contributor

@hlipsig hlipsig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SudoBrendan SudoBrendan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anonymous/unauthenticated access to this SA is a requirement, LGTM - I'm not sure if we need that or not?

pkg/deploy/assets/rp-oic.json Show resolved Hide resolved
pkg/deploy/assets/rp-oic.json Show resolved Hide resolved
@SudoBrendan SudoBrendan merged commit 42f3708 into Azure:master Feb 27, 2024
18 checks passed
cadenmarchese added a commit to cadenmarchese/ARO-RP that referenced this pull request Mar 5, 2024
UlrichSchlueter pushed a commit that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chainsaw Pull requests or issues owned by Team Chainsaw ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants