-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update network SDK to track2 #3594
Conversation
96ae6b6
to
a8a7b7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even it is in Draft mode as it depends on your other PR, LGTM. Thank you for this!
Please rebase pull request. |
a8a7b7e
to
123659a
Compare
/azp run ci,e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks.
Please rebase pull request. |
123659a
to
2d9d821
Compare
/azp run ci,e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-4665
What this PR does / why we need it:
This PR introduces new track2 SDK in cluster manager.
It relates to #3568
This is blocked by #3579
Test plan for issue:
This doesn't change/add any new behaviours.
Just compile check and code review is enough.
Is there any documentation that needs to be updated for this PR?
tech debt cleanup, N/A
How do you know this will function as expected in production?
This PR itself doesn't change/add any new behaviours.