ARO-8423: fix client generation issue with new Identity field for MIWI #3639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimorris27
added
ready-for-review
chainsaw
kimorris27
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
kimorris27
changed the title
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
tsatam
approved these changes
Jun 18, 2024
hlipsig
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
https://issues.redhat.com/browse/ARO-8423
What this PR does / why we need it:
This small change to the swagger generation code ensures that the
Identityfield, newly added for MIWI, is present on theOpenShiftClusterschema and in the generated clients.Test plan for issue:
N/A
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
The generated Python client will be used and tested as part of MIWI CLI development.