-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARO-9169] Remove disused clustermanager frontend code #3642
Conversation
/azp run ci, e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
9ae4dc4
to
2272ec6
Compare
/azp run ci, classic-pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Can you give some guidance on how to review this? I'm not super sure how to test this or what removing all this code means. If there's any supporting docs or anything I'd appreciate a link :) |
Please rebase pull request. |
2272ec6
to
11ebd08
Compare
11ebd08
to
e4a2223
Compare
/azp run ci, e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@mociarain , my understanding is that this code is related to some API endpoints for functionality that never ended up being used. And because Azure API docs are generated from code, these unused APIs are documented publicly... so every once in a while, we get an alert where a customer is trying to do something with one of these unsupported endpoints. It looks like this is the first in a series of PRs that will remove all of this cluster manager stuff.
The Jira epic description supports my understanding, which is why I'm comfortable approving.
Fixes https://issues.redhat.com/browse/ARO-9169
Removes the ClusterManager frontend code that is non-functional and won't be switched on.