Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase dev-proxy-vmss OSDisk to 64GB #3656

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

tsatam
Copy link
Collaborator

@tsatam tsatam commented Jul 1, 2024

Which issue this PR addresses:

Fixes no Jira

What this PR does / why we need it:

In #3562, we migrated our dev-proxy-vmss from a RHEL image to Mariner. This caused the OSDisk that we provision for these VM instances to shrink from 64GB to 5GB (RHEL -> Mariner image defaults).

This PR explicitly sets the OSDisk size to 64GB.

Test plan for issue:

  • Deploy dev-proxy-vmss and ensure it works

Is there any documentation that needs to be updated for this PR?

No

How do you know this will function as expected in production?

dev-proxy-vmss is not used in production.

@tony-schndr
Copy link
Collaborator

I deployed the VMSS and confirmed disk size is 64gb

@jaitaiwan
Copy link
Contributor

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jaitaiwan jaitaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

Copy link
Collaborator

@mociarain mociarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@cadenmarchese cadenmarchese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

@mociarain mociarain merged commit b6aec4e into master Jul 8, 2024
19 checks passed
@mociarain mociarain deleted the tsatam/hotfix-increase-dev-proxy-vmss-disk-size branch July 8, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants