[ARO-7788] Don't overwrite default installer version in local dev #3671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrWinston
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain and
AldoFusterTurpin
as code owners
mociarain
approved these changes
Jul 8, 2024
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
tiguelu
approved these changes
Jul 9, 2024
tiguelu
deleted the
mrwinston/ARO-7788-dont-overwrite-installer-version-in-local-env
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopened #3668 with branch in the correct repository.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-7788
What this PR does / why we need it:
Currently, the dev cluster creation tooling always makes sure that the default openshift version together with the default installer image is written to the cosmos db before creating the cluster. This however makes it impossible to use a custom installer image with the default openshift version, as any modifications to the installer image are overwritten.
This PR changes this behaviour so that the default version and installer image is only written when it is not already present.
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?