Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed context issue #3674

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

anshulvermapatel
Copy link
Collaborator

@anshulvermapatel anshulvermapatel commented Jul 9, 2024

Which issue this PR addresses:

Fixes a issue where a different context being used while doing get token call to azure than the one sent to individual db clients.

What this PR does / why we need it:

Test plan for issue:

Is there any documentation that needs to be updated for this PR?

How do you know this will function as expected in production?

@anshulvermapatel anshulvermapatel force-pushed the anshulvermapatel/cosmosdb-authorizer-context branch from 3e0cfce to cb9a49b Compare July 23, 2024 08:09
@anshulvermapatel anshulvermapatel changed the title [Draft]Fixed context issue Fixed context issue Jul 23, 2024
@anshulvermapatel anshulvermapatel added ready-for-review go Pull requests that update Go code firefly Issues or Pull requests owned by Team Firefly labels Jul 23, 2024
@anshulvermapatel anshulvermapatel marked this pull request as ready for review July 23, 2024 08:11
@SrinivasAtmakuri SrinivasAtmakuri added bug Something isn't working next-up labels Jul 23, 2024
@SrinivasAtmakuri SrinivasAtmakuri added release-blocker next-release To be included in the next RP release rollout labels Jul 23, 2024
@mociarain
Copy link
Collaborator

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@anshulvermapatel
Copy link
Collaborator Author

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@tiguelu tiguelu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mociarain mociarain merged commit 4b35728 into master Jul 23, 2024
21 checks passed
@mociarain mociarain deleted the anshulvermapatel/cosmosdb-authorizer-context branch July 23, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working firefly Issues or Pull requests owned by Team Firefly go Pull requests that update Go code next-release To be included in the next RP release rollout next-up ready-for-review release-blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants