-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create sp for each e2e run #3685
Conversation
/azp run ci,e2e |
Don't we need the unique SPs for the production E2E? |
b310715
to
fe0eafd
Compare
9d5697d
to
b05cc92
Compare
Not in the new tenant 😎 |
@@ -714,13 +728,28 @@ func (c *Cluster) deleteCluster(ctx context.Context, resourceGroup, clusterName | |||
return nil | |||
} | |||
|
|||
func (c *Cluster) deleteClusterResourceGroup(ctx context.Context, resourceGroup string) error { | |||
func (c *Cluster) ensureResourceGroupDeleted(ctx context.Context, resourceGroupName string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added due to some racey deletions and some stuff not getting cleaned up correctly in the new tenant. AFAIK in the past we were letting the VnetRG get cleaned up via the purge:true
flag (https://github.com/Azure/ARO-RP/pull/3513/files @tsatam can you confirm this). This just makes all the deletion a bit more explicit but we still have the purge script as a fall back
/azp run ci |
Azure Pipelines successfully started running 1 pipeline(s). |
dcb5ece
to
042fc45
Compare
042fc45
to
a941ecd
Compare
/azp run ci |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run ci |
Azure Pipelines successfully started running 1 pipeline(s). |
Which issue this PR addresses:
Ticket
This PR: