Drop SyncSets check #3723
Merged
Drop SyncSets check #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mociarain
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
AldoFusterTurpin,
kimorris27 and
tsatam
as code owners
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mociarain
force-pushed
the
mociarain/7787
branch
from
9435958
to
cb566c4
Compare
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tsatam
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Change and motivation LGTM.
I'm curious if we should still keep an explicit SyncSets ready check at the end of our install process, just to make sure we don't have any WIP before we hand the cluster over to the user, but that can be introduced whenever we actually start using SyncSets.
kimorris27
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes: https://issues.redhat.com/browse/ARO-7787
What this PR does / why we need it:
This PR drops the sync sets check from
IsClusterDeploymentReady.Monitoring of SyncSets will come as part of it's own monitoring in the future and since we have no SyncSets at present there is no temporary gap.
Test plan for issue:
Tested locally using the dev Hive