-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added known issues and a session of when to use #3737
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehvs
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
AldoFusterTurpin,
kimorris27 and
tsatam
as code owners
July 30, 2024 07:43
/azp run ci, e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
mociarain
reviewed
Jul 30, 2024
Co-authored-by: Maitiú Ó Ciaráin <[email protected]>
Co-authored-by: Maitiú Ó Ciaráin <[email protected]>
Azure Pipelines successfully started running 2 pipeline(s). |
mociarain
previously approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bitoku
reviewed
Jul 30, 2024
AldoFusterTurpin
previously approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Ayato Tokubi <[email protected]>
Co-authored-by: Ayato Tokubi <[email protected]>
bitoku
approved these changes
Aug 2, 2024
/azp run ci |
Azure Pipelines successfully started running 1 pipeline(s). |
mociarain
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Non-clarity of when to use local dev RP, or when to use the full RP service.
What this PR does / why we need it:
Make it more clear when to build a local dev RP, or when to use the full RP service.
And a added a Known Issues session for common errors situations.
Test plan for issue:
Not needed