Fix NotFound error in DNS isn't handled properly #3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitoku
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
AldoFusterTurpin,
kimorris27 and
tsatam
as code owners
mociarain
reviewed
Jul 30, 2024
bitoku
force-pushed
the
atokubi/dns-deletion-bugfix
branch
from
983cb2e
to
0aed6cf
Compare
|
I force-pushed this time again, but you can compare it with the previous one from |
|
I found another problem in DNS manager. I'll make it hold to fix all of them. |
bitoku
changed the title
bitoku
force-pushed
the
atokubi/dns-deletion-bugfix
branch
from
0aed6cf
to
2143cb8
Compare
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
mociarain
approved these changes
Jul 30, 2024
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes N/A
What this PR does / why we need it:
In a part of other task, I found it failed to delete a cluster when dns records are already deleted.
This was caused by the update of the sdk to track2.
Since track2, autorest has been deprecated, we needed to change it to ResponseError.
cf. https://github.com/Azure/go-autorest
https://github.com/Azure/azure-sdk-for-go/blob/e302bb60ef995455b0eaabf590a75c8396e32834/sdk/azcore/internal/exported/response_error.go#L112
I found https://pkg.go.dev/github.com/Azure/azure-sdk-for-go-extensions/pkg/errors#IsNotFoundErr this repository but we can't use it, because the error we get is
NotFound, but it checks if the error isResourceNotFound.Probably this discrepancy might come from the Azure API server, but anyway we can't use it.
Test plan for issue:
Delete a dev cluster with dns records already deleted.
Unit test (it couldn't find the error when we updated the sdk though)
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
Delete a cluster with dns records already deleted.