Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change load balancer image in smoke test #3740

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

bitoku
Copy link
Collaborator

@bitoku bitoku commented Jul 30, 2024

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-7350

What this PR does / why we need it:

This is a followup of #3717 .
Apparently the image nginx is not compliant to MSFT security advisory.
https://msazure.visualstudio.com/AzureRedHatOpenShift/_build/results?buildId=99367257&view=logs&j=10f66467-59e5-53bc-0c8a-42cc89770de4&t=22254a09-0937-5b6f-413f-542ad48300e2&l=28
I followed the warning and modified tests accordingly.

Test plan for issue:

Run tests locally.

Is there any documentation that needs to be updated for this PR?

N/A

How do you know this will function as expected in production?

Check CI status.

@bitoku
Copy link
Collaborator Author

bitoku commented Jul 30, 2024

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

@AldoFusterTurpin AldoFusterTurpin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a question. Thank you!

test/e2e/ocp_loadbalancer.go Outdated Show resolved Hide resolved
@bitoku
Copy link
Collaborator Author

bitoku commented Jul 31, 2024

/azp run ci,e2e

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@bitoku
Copy link
Collaborator Author

bitoku commented Aug 1, 2024

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tiguelu tiguelu merged commit c74906d into master Aug 16, 2024
21 checks passed
@tiguelu tiguelu deleted the atokubi/fix-ci-warning branch August 16, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants