ARO-4639 update the operator master deployment to support workload identity #3776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yithian
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
AldoFusterTurpin,
kimorris27 and
tsatam
as code owners
yithian
force-pushed
the
yithian/ARO-4639
branch
from
6409e5c
to
d29d6cb
Compare
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kimorris27
reviewed
Aug 19, 2024
SudoBrendan
requested changes
Aug 19, 2024
yithian
force-pushed
the
yithian/ARO-4639
branch
2 times, most recently
from
49501a7
to
3269780
Compare
|
Please rebase pull request. |
yithian
force-pushed
the
yithian/ARO-4639
branch
from
3269780
to
f00e460
Compare
yithian
force-pushed
the
yithian/ARO-4639
branch
from
f00e460
to
738fa93
Compare
SudoBrendan
previously approved these changes
Aug 20, 2024
|
Putting a hold on this until #3761 is merged, as this was rebased onto that to pull in the token file location/mountpoint |
|
#3761 is merged, removing my hold |
|
Please rebase pull request. |
This causes the spec for the operator master deployment to mount the service account token as a volume, and maps the path to the environment variable expected by Azure to support workload identities
yithian
force-pushed
the
yithian/ARO-4639
branch
from
738fa93
to
1c88479
Compare
bitoku
reviewed
Sep 2, 2024
yithian
force-pushed
the
yithian/ARO-4639
branch
from
f130eb1
to
be0f53f
Compare
cadenmarchese
approved these changes
Sep 17, 2024
rajdeepc2792
approved these changes
Sep 17, 2024
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kimorris27
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-4639
What this PR does / why we need it:
This causes the spec for the operator master deployment to mount the service account token as a volume, and maps the path to the environment variable expected by Azure to support workload identities
Test plan for issue:
Unit tests confirm that the generated yaml is valid and will be applied to a test cluster to confirm that it's a valid OpenShift resource as well
Is there any documentation that needs to be updated for this PR?
No, part of larger project of adding support for MIWI
How do you know this will function as expected in production?
As with all MIWI support work, it will be extremely challenging to test until we have a way to provision a MIWI cluster. Applying the updated generated resource to a test cluster will probably be the best we can do until then