Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Fluenbit Image #3780

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Copy Fluenbit Image #3780

merged 2 commits into from
Aug 28, 2024

Conversation

razo7
Copy link
Collaborator

@razo7 razo7 commented Aug 19, 2024

What this PR does / why we need it:

Fix an error on missing fluentbit image which is compared against a default image (and digest) and to fix it a user must fetch it from arointsvc ACR.
See also the full discussion on Slack.

ARO-RP git:(master) docker pull rootaro.azurecr.io/fluentbit:1.9.10-cm20240301@sha256:5a6a6987a1e8d4223b7e64524117cb294acbd7a0b10f813f298d4f632efe3c4f
Trying to pull rootaro.azurecr.io/fluentbit@sha256:5a6a6987a1e8d4223b7e64524117cb294acbd7a0b10f813f298d4f632efe3c4f...
Error: initializing source docker://rootaro.azurecr.io/fluentbit@sha256:5a6a6987a1e8d4223b7e64524117cb294acbd7a0b10f813f298d4f632efe3c4f: reading manifest sha256:5a6a6987a1e8d4223b7e64524117cb294acbd7a0b10f813f298d4f632efe3c4f in rootaro.azurecr.io/fluentbit: manifest unknown: manifest sha256:5a6a6987a1e8d4223b7e64524117cb294acbd7a0b10f813f298d4f632efe3c4f is not found

Test plan for issue:

Is there any documentation that needs to be updated for this PR?

Yes, included.

How do you know this will function as expected in production?

Indent bullet points
It is needed since it is compared against a default image (and digest) from const file
@razo7
Copy link
Collaborator Author

razo7 commented Aug 19, 2024

/azp run ci, e2e

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@SudoBrendan
Copy link
Collaborator

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mociarain mociarain merged commit 5dfba05 into master Aug 28, 2024
21 checks passed
@mociarain mociarain deleted the copy-fluentbit branch August 28, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants