ARO-9382 prevent updating existing platform identities #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yithian
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27 and
tsatam
as code owners
yithian
force-pushed
the
yithian/ARO-9382
branch
2 times, most recently
from
98d15ab
to
db93126
Compare
tsatam
requested changes
Aug 21, 2024
yithian
force-pushed
the
yithian/ARO-9382
branch
from
db93126
to
0607a3a
Compare
kimorris27
requested changes
Aug 22, 2024
This adds a check to v20240812preview static validation that raises an error if either the name or resource ID of an existing platform identity
This allows changing the order of platform identities while still preventing the resource ID and operator name from being changed
This prevents removal of a platform identity or changing the identity's OperatorName and ResourceID at the same time
yithian
force-pushed
the
yithian/ARO-9382
branch
from
0607a3a
to
4258dd1
Compare
rajdeepc2792
requested changes
Sep 17, 2024
yithian
force-pushed
the
yithian/ARO-9382
branch
from
a5d9aa4
to
b9e4123
Compare
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
yithian
force-pushed
the
yithian/ARO-9382
branch
from
b9e4123
to
5ed140e
Compare
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
slawande2
reviewed
Sep 17, 2024
kimorris27
approved these changes
Sep 17, 2024
It was copied, not moved. We maintain separate OpenShiftCluster struct definitions for each individual APIversion we support, so we'd need to maintain duplicate functions for each struct as well. |
tsatam
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-9382
What this PR does / why we need it:
This adds a check to v20240812preview static validation that raises an error if either the name or resource ID of an existing platform identity
Test plan for issue:
Unit tests
Is there any documentation that needs to be updated for this PR?
This is part of the general managed identity / workload identity feature development and this change should be reflected in the final documentation
How do you know this will function as expected in production?
Unit tests for now