Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffolding for CI environment setup in Azure #3838

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

jhoreman
Copy link
Contributor

Which issue this PR addresses:

https://issues.redhat.com/browse/ARO-10133

What this PR does / why we need it:

Scaffolding for CI env buildouts as per our go generator/ARM deploy scripts. Mostly a stub for now as it only lays down a resource group and an ACR. Meant to be added to when we deploy more infra in the CI/E2E sub.

Test plan for issue:

Copy link
Collaborator

@SudoBrendan SudoBrendan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - if we can let's validate the default ACR Name is correct

pkg/deploy/generator/templates_ci.go Show resolved Hide resolved
@SudoBrendan
Copy link
Collaborator

/azp run ci

@SudoBrendan
Copy link
Collaborator

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@shubhadapaithankar shubhadapaithankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SudoBrendan SudoBrendan merged commit 68bc932 into master Sep 19, 2024
23 checks passed
@SudoBrendan SudoBrendan deleted the jhoreman/ci-acr-setup branch September 19, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants