SDK2: Remove deprecated network sdk from e2e. #3859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitoku
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27 and
tsatam
as code owners
bitoku
force-pushed
the
sdk2/e2e
branch
3 times, most recently
from
147ee9d
to
10eb5b8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run e2e |
kimorris27
previously approved these changes
Sep 24, 2024
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please rebase pull request. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kimorris27
approved these changes
Sep 27, 2024
tiguelu
reviewed
Sep 27, 2024
tiguelu
approved these changes
Sep 27, 2024
slawande2
pushed a commit
that referenced
this pull request
Oct 2, 2024
* subnets * remove deprecated security group usage from e2e setup * remove deprecated interface sdk from e2e. * remove deprecated loadbalancer sdk from e2e. * remove deprecated virtual networks sdk from e2e. * remove deprecated subnets sdk from e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-4665
What this PR does / why we need it:
This PR removes deprecated network sdk from e2e.
Test plan for issue:
e2e
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
Mostly the changes are nothing to do with prod.
Only monitor nsg has a small change because of the subnets client change.
We can validate the monitor nsg function by checking these metrics.