Remove pipeline chaining from our E2E pipeline #3874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-triggers and it duplicates all e2e builds
hawkowl
requested review from
jewzaam,
bennerv,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
hawkowl
added
size-small
tsatam
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
I'm fine with this as a temporary fix for the duplicated E2E pipeline execution, but long term we'll be moving the E2E stage to be directly within the CI pipeline (and use the aro artifacts built during CI for E2E), the WIP PR is here: #3856
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Back when we had automatically triggering ADO pipelines (which we don't have because "require comment by contributor" is locked on at the org level) it was convenient to have the CI run and then the e2e trigger off a successful CI run to reduce pointless E2E runs. Now that we have to do the
/azp runcommand (which triggers CI + E2E), we can end up with cases where the E2E will be manually triggered but also secondarily triggered from the successful CI run for the same commit (an example from this week):This removes this e2e duplication, which fills up the E2E queue pointlessly and never ends up assigned to the GitHub check anyway.
I've also disabled overriding the YAML in the e2e.yml file in the UI, so it will use these values.
Test plan for issue:
Is CI/E2E based